Skip to content

[1/2] Leave scripts out of html5 frame capture #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dazzatronus merged 1 commit into from
Oct 8, 2026
Merged

[1/2] Leave scripts out of html5 frame capture #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/canvas/players/html5-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,8 @@ export class Html5Player extends Player {
.join("");
const animationOverride = `<style>*,*::before,*::after{animation:none!important;transition:none!important}</style>`;
const bodyClone = doc.body.cloneNode(true) as HTMLElement;
// Scripts never run in an SVG image, and their source can hold characters XML forbids, which fail the frame.
bodyClone.querySelectorAll("script").forEach(script => script.remove());
const existingStyle = bodyClone.getAttribute("style") ?? "";
bodyClone.setAttribute("style", `width:${width}px;height:${height}px;margin:0;overflow:hidden;${existingStyle}`);
const bodyXml = serializer.serializeToString(bodyClone);
Expand Down
15 changes: 15 additions & 0 deletions tests/html5-player.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,21 @@ it("captures inline SVG backgrounds and CSS metacharacters as valid XML without
expect(doc.head.querySelector("style")?.textContent).toBe(css);
});

it("leaves scripts out of the capture so their source can't break the frame", () => {
const { harness, iframe } = createPlayer();
const doc = iframe.contentDocument!;
const script = doc.createElement("script");
script.textContent = 'const unit = "\u0001";';
doc.body.replaceChildren(script, Object.assign(doc.createElement("div"), { className: "title", textContent: "Shown" }));

const parsed = new DOMParser().parseFromString(harness.captureIframeAsForeignObjectSvg(1080, 1920), "image/svg+xml");

expect(parsed.querySelector("parsererror")).toBeNull();
expect(parsed.querySelector("script")).toBeNull();
expect(parsed.querySelector(".title")?.textContent).toBe("Shown");
expect(doc.body.querySelector("script")).not.toBeNull();
});

it("keeps a failed capture inside its canvas layer and retries only after the asset changes", async () => {
const { player, harness, iframe, events, edit } = createPlayer();
jest.spyOn(console, "warn").mockImplementation(() => {});
Expand Down
Loading