Repository navigation
feat: Support multi-configuration OID4VCI issuance - #469
Merged
Merged
Conversation
- keep decrypted responses per credential configuration - match completed flows per configuration - answer `user_selects` with everything for now
🦋 Changeset detectedLatest commit: e418449 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8 of 20 tasks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A pending decryption can restore credentials and secret metadata after cancellation, disconnect, or key regeneration because the result is stored without verifying that the flow still owns the same key entry.
1 open issue
What changed in this PR
Adds multi-configuration OID4VCI issuance support, allowing the wallet to handle credentials with different encryption settings within one flow.
Changes:
- Tracks decrypted responses, metadata, notifications, and failures per configuration.
- Automatically selects all offered configurations for
user_selectsflows. - Prepares and validates separate storage batches per configuration, with expanded regression tests.
| File | Description |
|---|---|
src/lib/openid-flow/utils/credentialNotifications.ts |
Uses the renamed notificationId field. |
src/lib/openid-flow/types/OID4VCITypes.ts |
Adds per-credential configuration and metadata fields, plus configuration failures. |
src/lib/openid-flow/transports/OIDFlowWebSocketTransport.ts |
Matches completion results per configuration and handles automatic selection. |
src/lib/openid-flow/encryption/ClientHeldEncryptionKeys.ts |
Retains decrypted responses and encryption-offer state per configuration. |
src/lib/openid-flow/encryption/ClientHeldEncryptionKeys.test.ts |
Tests configuration isolation, key replacement, and response retention. |
src/lib/openid-flow/__tests__/OIDFlowWebSocketTransport.test.ts |
Covers multi-configuration completion, partial failures, and selection. |
src/lib/openid-flow/__tests__/OIDFlowNotification.test.ts |
Updates notification tests for notificationId. |
src/hooks/useOID4VCIFlow.ts |
Groups credentials into configuration-specific batches before storage. |
.changeset/bumpy-ghosts-wonder.md |
Records the feature as a minor release change. |
Review effort: Balanced
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Support scenarios where during issuance, multiple credentials are issued in the same flow.
We need to handle each of these, since they could have different encryption configurations,
and validate and group them before storage.
Type of change
Related issues / tickets
Changes
user_selectswith everything for nowChecklist
Security checklist
Notes for reviewers