Repository navigation
fix(tick durations): handle an empty sample of tick times - #319
Open
MarvinKlar wants to merge 1 commit into
Open
MarvinKlar wants to merge 1 commit into
MarvinKlar wants to merge 1 commit into
Conversation
A server that has not ticked yet reports an empty sample. The collectors indexed into that array right away, so a scrape during startup failed with an ArrayIndexOutOfBoundsException (median) and an ArithmeticException (average), while min and max silently reported Long.MAX_VALUE and Long.MIN_VALUE. All four collectors now report NaN until the server has ticked. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A server that has not ticked yet reports an empty sample. The collectors indexed into that array right away, so a scrape during startup failed with an ArrayIndexOutOfBoundsException (median) and an ArithmeticException (average), while min and max silently reported Long.MAX_VALUE and Long.MIN_VALUE.
All four collectors now report NaN until the server has ticked.