Repository navigation
Conversation
Carve-out 2/6 of the API endpoint review (PR #2697), money routes only: - payments transfers and transfer-batches gain an explicit /execute step - ramps quote -> start (it opens a tracked provider flow), currency lists -> supported-pairs, counterparties requirements -> ramp-requirements (check) and field-options, payment request link returns a link token - DvP custody-wallet wording becomes connected-wallet/provider-signed - update dashboard calls, playground configs, homepage snippets, the idempotency guide, integration tests, and regenerate catalogs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
[Medium impact] The PR appears safe to merge, with no outstanding findings. SummaryRenames payment and ramp routes and updates dashboard calls, examples, and generated catalogs.
Reviews (3) · Last reviewed commit: "docs(api): point the publicToken schema ..." · Reviewed by Greptile |
keeganthomp
left a comment
There was a problem hiding this comment.
The route renames still leave recovery and caller mismatches.
|
|
||
| transfers.post( | ||
| "/", | ||
| "/execute", |
There was a problem hiding this comment.
Retries of transfers created before this rename hit IDEMPOTENCY_KEY_REUSED; batches hit TRANSFER_BATCH_RUN_EXISTS because their saved fingerprints include the matched path. Preserve the old operation identity when resolving existing records so the same key and body can recover their original result.
| ); | ||
| paymentRequests.get( | ||
| "/:paymentRequestId/link", | ||
| "/:paymentRequestId/link-token", |
There was a problem hiding this comment.
OpenAPI still publishes /requests/{paymentRequestId}/link, so generated playground and Postman calls now return 404. Rename the published path to /link-token and regenerate its dependents.
| ): Promise<FetchResult<CustodyWalletAggregate>> { | ||
| try { | ||
| const response = await request("/v1/wallets/aggregate"); | ||
| const response = await request("/v1/wallets/balances/aggregate"); |
There was a problem hiding this comment.
This now requests /wallets/balances/aggregate, but this PR still serves /wallets/aggregate, so aggregate reads return 404. Move the matching router rename from #2928 into this PR.
|
|
||
| transfers.post( | ||
| "/", | ||
| "/execute", |
There was a problem hiding this comment.
scripts/fireblocks-live.mjs and the regulated-stablecoin tutorial still POST to /v1/payments/transfers, which now returns 404. Update the remaining callers and runnable examples alongside this rename.
…s and catalogs
- idempotent() gains a previousOperation option so a retry of a transfer or
batch saved under the old route replays from its domain row instead of
answering 422 (IDEMPOTENCY_KEY_REUSED / TRANSFER_BATCH_RUN_EXISTS)
- move the wallets aggregate rename into this PR: the API now serves
GET /v1/wallets/balances/aggregate, matching this PR's dashboard caller
- restore /v1/issuance/tokens/{id}/mint in the payment E2E setups: this PR's
issuance router does not serve /execute (that rename is #2926's)
- publish the payment-request link route as /link-token in OpenAPI and
regenerate the playground catalog, Postman collection and llms-full
- point scripts/fireblocks-live.mjs and the regulated-stablecoin tutorial at
POST /v1/payments/transfers/execute
- list the real wallet initialization route in the idempotency guide and
describe the DvP create signer correctly (the sponsor signs; neither party
approves at creation)
Carve-out 2/6 of the API endpoint review (PR #2697), money routes only: