Skip to content

refactor(api): clarify payments, ramps and DvP route names - #2925

Open
cutbow7 wants to merge 3 commits into
mainfrom
codex/api-review-2-payments
Open

cutbow7 wants to merge 3 commits into
mainfrom
codex/api-review-2-payments

Conversation

@cutbow7

@cutbow7 cutbow7 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Carve-out 2/6 of the API endpoint review (PR #2697), money routes only:

  • payments transfers and transfer-batches gain an explicit /execute step
  • ramps quote -> start (it opens a tracked provider flow), currency lists -> supported-pairs, counterparties requirements -> ramp-requirements (check) and field-options, payment request link returns a link token
  • DvP custody-wallet wording becomes connected-wallet/provider-signed
  • update dashboard calls, playground configs, homepage snippets, the idempotency guide, integration tests, and regenerate catalogs

Carve-out 2/6 of the API endpoint review (PR #2697), money routes only:
- payments transfers and transfer-batches gain an explicit /execute step
- ramps quote -> start (it opens a tracked provider flow), currency
  lists -> supported-pairs, counterparties requirements ->
  ramp-requirements (check) and field-options, payment request link
  returns a link token
- DvP custody-wallet wording becomes connected-wallet/provider-signed
- update dashboard calls, playground configs, homepage snippets, the
  idempotency guide, integration tests, and regenerate catalogs
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sdp-docs Ready Ready Preview Nov 21, 2026 11:24pm UTC
sdp-web Ready Ready Preview Nov 21, 2026 11:24pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
sdp-docs-beta Ignored Ignored Preview Nov 21, 2026 11:24pm UTC
sdp-web-beta Skipped Skipped Nov 21, 2026 11:24pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 19e38d7.

@cutbow7
cutbow7 added this pull request to stack #2927 November 20, 2026 09:26
@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with no outstanding findings.

Summary

Renames payment and ramp routes and updates dashboard calls, examples, and generated catalogs.

  • Transfers and payout batches use explicit execution routes.
  • Ramp and counterparty routes name the supported pairs and setup steps.
  • Recurring payment, payment-request, and wallet routes name their actions.
  • DvP descriptions call provider wallets connected wallets and name the sponsor signer.

Reviews (3) · Last reviewed commit: "docs(api): point the publicToken schema ..." · Reviewed by Greptile

Comment thread apps/sdp-api/src/openapi/paths/dvp.ts Resolved

@keeganthomp keeganthomp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The route renames still leave recovery and caller mismatches.


transfers.post(
"/",
"/execute",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retries of transfers created before this rename hit IDEMPOTENCY_KEY_REUSED; batches hit TRANSFER_BATCH_RUN_EXISTS because their saved fingerprints include the matched path. Preserve the old operation identity when resolving existing records so the same key and body can recover their original result.

);
paymentRequests.get(
"/:paymentRequestId/link",
"/:paymentRequestId/link-token",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenAPI still publishes /requests/{paymentRequestId}/link, so generated playground and Postman calls now return 404. Rename the published path to /link-token and regenerate its dependents.

): Promise<FetchResult<CustodyWalletAggregate>> {
try {
const response = await request("/v1/wallets/aggregate");
const response = await request("/v1/wallets/balances/aggregate");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now requests /wallets/balances/aggregate, but this PR still serves /wallets/aggregate, so aggregate reads return 404. Move the matching router rename from #2928 into this PR.


transfers.post(
"/",
"/execute",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/fireblocks-live.mjs and the regulated-stablecoin tutorial still POST to /v1/payments/transfers, which now returns 404. Update the remaining callers and runnable examples alongside this rename.

…s and catalogs

- idempotent() gains a previousOperation option so a retry of a transfer or
  batch saved under the old route replays from its domain row instead of
  answering 422 (IDEMPOTENCY_KEY_REUSED / TRANSFER_BATCH_RUN_EXISTS)
- move the wallets aggregate rename into this PR: the API now serves
  GET /v1/wallets/balances/aggregate, matching this PR's dashboard caller
- restore /v1/issuance/tokens/{id}/mint in the payment E2E setups: this PR's
  issuance router does not serve /execute (that rename is #2926's)
- publish the payment-request link route as /link-token in OpenAPI and
  regenerate the playground catalog, Postman collection and llms-full
- point scripts/fireblocks-live.mjs and the regulated-stablecoin tutorial at
  POST /v1/payments/transfers/execute
- list the real wallet initialization route in the idempotency guide and
  describe the DvP create signer correctly (the sponsor signs; neither party
  approves at creation)

This branch was successfully deployed

2 active deployments
Preview – sdp-docs — 19e38d75 Deployed Nov 21, 2026 by vercel[bot]
Preview – sdp-web — 19e38d75 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants