Repository navigation
test(payments): tighten payment request tests to behavior and invariants - #2935
Open
multipletwigs wants to merge 4 commits into
Open
multipletwigs wants to merge 4 commits into
multipletwigs wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
[Low impact] The PR appears safe to merge; no new blocking issues were found. SummaryTightens payment-request tests and adds shared API and web fixtures.
Reviews (8) · Last reviewed commit: "test(payments): pin the sponsorship expi..." · Reviewed by Greptile |
multipletwigs
force-pushed
the
zach/prune-payment-request-tests
branch
from
November 20, 2026 10:14
56688d4 to
7069e11
Compare
multipletwigs
force-pushed
the
zach/prune-payment-request-tests
branch
from
November 20, 2026 10:17
7069e11 to
5f8e594
Compare
multipletwigs
force-pushed
the
zach/prune-payment-request-tests
branch
from
November 20, 2026 10:32
383717a to
da253a8
Compare
multipletwigs
force-pushed
the
zach/prune-payment-request-tests
branch
from
November 20, 2026 10:58
a87c58e to
1e44e24
Compare
multipletwigs
force-pushed
the
zach/prune-payment-request-tests
branch
from
November 20, 2026 11:07
1e44e24 to
e5f73d5
Compare
…itory, not the system factory
… request statuses from payable
multipletwigs
force-pushed
the
zach/prune-payment-request-tests
branch
from
November 20, 2026 11:19
e5f73d5 to
2644d54
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tightens payment request tests in sdp-api and sdp-web, including the public pay page. Stacked on the subscriptions PR.
payment-request-tenant.ts(API) andtest/payment-requests.ts(web).Verification:
verify-changedtypecheck and biome pass on the full stack. Vitest and Playwright not run locally (CI runs them). An independent review checked every removed test for a replacement through the same entry point; uncovered behavior was restored before push.