Skip to content

feat(safe-proxy): add the sdp-safe-proxy app with a liveness route - #2940

Open
multipletwigs wants to merge 6 commits into
mainfrom
bashtwigs/pro-2502-safe-proxy-app-scaffold
Open

multipletwigs wants to merge 6 commits into
mainfrom
bashtwigs/pro-2502-safe-proxy-app-scaffold

Conversation

@multipletwigs

@multipletwigs multipletwigs commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Adds apps/sdp-safe-proxy, a new workspace app that will hold provider credentials and make provider calls for the API. This first step is the project only: it starts, answers a liveness route, and does nothing else yet. It installs Kit 8 while the rest of the repo stays on Kit 7.

  • GET /health is constant and touches no dependency.
  • SDP_SAFE_PROXY_PORT is required with no default in code, parsed with Zod. A missing or invalid value exits 1 and names the setting, never its value. pnpm dev sets it to 8791.
  • Kit 8.6.0 is a dependency of this app only. Nothing imports it yet; the first signing operation will.
  • Four Kit 7 modules now state packages they previously left to the installer (@solana/keys, @solana/transactions, @solana/sysvars, two rpc-subscriptions packages), with three new catalog entries at 7.1.1. Without this, a second Kit major in the workspace changes what their libraries resolve to.
  • No existing module's resolved version changes: compared against main, only the new app and the newly stated entries are added to the lockfile.
  • The app may depend on no workspace package yet (empty allow-list in check-module-boundaries.mjs; module map regenerated).

Verification: full typecheck 32/32, biome on the app, module-boundary and pinned-dependency checks, frozen install. Local run: pnpm dev answered GET /health with {"status":"ok"} on 8791; no port setting and a non-numeric one both exited 1; the app loads Kit 8.6.0. No tests added or run locally.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sdp-docs Ready Ready Preview Nov 20, 2026 6:10pm UTC
sdp-web Ready Ready Preview Nov 20, 2026 6:10pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
sdp-docs-beta Skipped Skipped Nov 20, 2026 6:10pm UTC
sdp-web-beta Skipped Skipped Nov 20, 2026 6:10pm UTC

Request Review

@linear

linear Bot commented Nov 20, 2026

Copy link
Copy Markdown

PRO-2502

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The PR adds a standalone HTTP service but does not connect it to existing API workflows.

The PR still needs the previously reported fix for proxy port collisions between worktrees before merging.

Findings

  1. P1 Second worktree proxy cannot start ▶

Summary

Adds @sdp/safe-proxy with a constant GET /health route.

  • The Safe Proxy server starts and answers a dependency-free health check.
  • Existing workspace packages now name the Kit 7 dependencies they use.

The earlier, unnumbered Zod finding is fixed.

Reviews (5) · Last reviewed commit: "chore(safe-proxy): start the dev script ..." · Reviewed by Greptile

Comment thread apps/sdp-safe-proxy/src/settings.ts Resolved
"private": true,
"type": "module",
"scripts": {
"dev": "SDP_SAFE_PROXY_PORT=8791 node --import tsx src/server.ts",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Second worktree proxy cannot start

Root pnpm dev picks up this new script through the unfiltered turbo run dev. The launcher assigns separate ports to concurrent worktrees, but this script makes every proxy bind 8791. The second worktree’s proxy therefore exits with EADDRINUSE while its other apps keep running.

Add the proxy to the existing port allocator and let this script use the assigned SDP_SAFE_PROXY_PORT instead of overwriting it.

This branch was successfully deployed

2 active deployments
Preview – sdp-docs — 2eaca305 Deployed Nov 20, 2026 by vercel[bot]
Preview – sdp-web — 2eaca305 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant