Repository navigation
feat(safe-proxy): add the sdp-safe-proxy app with a liveness route - #2940
multipletwigs wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
[Medium impact] The PR adds a standalone HTTP service but does not connect it to existing API workflows. The PR still needs the previously reported fix for proxy port collisions between worktrees before merging. Findings
SummaryAdds
The earlier, unnumbered Zod finding is fixed. Reviews (5) · Last reviewed commit: "chore(safe-proxy): start the dev script ..." · Reviewed by Greptile |
…ackages other modules rely on
…d a dev script on 8788
| "private": true, | ||
| "type": "module", | ||
| "scripts": { | ||
| "dev": "SDP_SAFE_PROXY_PORT=8791 node --import tsx src/server.ts", |
There was a problem hiding this comment.
Second worktree proxy cannot start
Root pnpm dev picks up this new script through the unfiltered turbo run dev. The launcher assigns separate ports to concurrent worktrees, but this script makes every proxy bind 8791. The second worktree’s proxy therefore exits with EADDRINUSE while its other apps keep running.
Add the proxy to the existing port allocator and let this script use the assigned SDP_SAFE_PROXY_PORT instead of overwriting it.
Adds
apps/sdp-safe-proxy, a new workspace app that will hold provider credentials and make provider calls for the API. This first step is the project only: it starts, answers a liveness route, and does nothing else yet. It installs Kit 8 while the rest of the repo stays on Kit 7.GET /healthis constant and touches no dependency.SDP_SAFE_PROXY_PORTis required with no default in code, parsed with Zod. A missing or invalid value exits 1 and names the setting, never its value.pnpm devsets it to 8791.@solana/keys,@solana/transactions,@solana/sysvars, tworpc-subscriptionspackages), with three new catalog entries at 7.1.1. Without this, a second Kit major in the workspace changes what their libraries resolve to.check-module-boundaries.mjs; module map regenerated).Verification: full typecheck 32/32, biome on the app, module-boundary and pinned-dependency checks, frozen install. Local run:
pnpm devansweredGET /healthwith{"status":"ok"}on 8791; no port setting and a non-numeric one both exited 1; the app loads Kit 8.6.0. No tests added or run locally.