Conversation
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when a DPU module encounters a kernel panic and restarts,
chassisdtransitions to theDPU_STATE_WAIT_FOR_SELF_RECOVERYstate and waits for a full 300-second (5-minute) grace period to elapse before performing a recovery power cycle. Since a kernel panic is an unrecoverable state, waiting for this timeout causes unnecessary downtime.This PR modifies the state machine in
chassisdto check the reboot cause. If the cause matches"kernel panic", it immediately bypasses the 300-second wait time and directly triggers a recovery power-cycle to restore services as fast as possible.Changes Made
update_dpu_recovery_state()inchassisdto queryget_reboot_cause(). If the cause or its details contain"kernel panic", the 300-second self-recovery timeout is bypassed, and the state machine directly entersDPU_STATE_POWER_CYCLE(orManualInterventionif auto-recovery is disabled).test_self_recovery_kernel_panic_bypasses_grace_period()intests/test_dpu_auto_recovery.pyto verify that a mocked kernel panic reboot cause bypasses the waiting period.os.symlinktoshutil.copyinpersist_dpu_reboot_cause()to prevent Windows administrative privilege errors during testing.sonic-chassisd/tests/conftest.pyto support unit test verification on Windows environments.Verification
============================= 140 passed in 2.54s =============================