Skip to content

Add speed_rpm field support for fans - #888

Open
meetshamsher wants to merge 2 commits into
sonic-net:masterfrom
meetshamsher:fan_speed_rpm
Open

meetshamsher wants to merge 2 commits into
sonic-net:masterfrom
meetshamsher:fan_speed_rpm

Conversation

@meetshamsher

@meetshamsher meetshamsher commented Sep 3, 2026

Copy link
Copy Markdown

Description

To populate redis DB with fan speed in RPM, for same a new DB entry has been made with "speed_rpm".

Motivation and Context

Currently we are showing fan speed in %age and a new requirement came to populate fan speed in rpm which is not getting saved in redis DB. Therefore one entry has been made as "speed_rpm" to populate fan speed with rpm values.

How Has This Been Tested?

Loaded image in local target and checked for rdis-db data population as show below:
Note: the setup contains two PSU and 4 Fan tray with each two fans.
Checked for redis DB entry is getting updated properly, without affecting current fanshow display.
Note: this is only to update DB with fan speed with RPM values. Along-with existing speed in %age.
Test log :
root@sonic:/home/admin# for k in $(sonic-db-cli STATE_DB KEYS "FAN_INFO|*"); do echo "=== $k ==="; sonic-db-cli STATE_DB HGETALL "$k"; echo; done
=== FAN_INFO|PSU1.fan1 ===
{'presence': 'True', 'status': 'True', 'direction': 'N/A', 'speed': '50', 'speed_rpm': '10080', 'timestamp': '20260602 11:06:27', 'led_status': 'N/A', 'drawer_name': 'N/A', 'model': 'NXA-PAC-500W-PE', 'serial': 'LIT2709A9HY', 'speed_target': '50', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False'}

=== FAN_INFO|fantray1.fan1 ===
{'presence': 'True', 'drawer_name': 'fantray1', 'model': 'NXA-SFAN-35CFM-PE', 'serial': 'DCH2936TJEW25372537A0', 'status': 'True', 'direction': 'exhaust', 'speed': '49', 'speed_rpm': '12134', 'speed_target': '53', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False', 'timestamp': '20260602 11:06:27', 'led_status': 'green'}

=== FAN_INFO|fantray2.fan2 ===
{'presence': 'True', 'drawer_name': 'fantray2', 'model': 'NXA-SFAN-35CFM-PE', 'serial': 'DCH2936TJ9625372537A0', 'status': 'True', 'direction': 'exhaust', 'speed': '49', 'speed_rpm': '10305', 'speed_target': '53', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False', 'timestamp': '20260602 11:06:27', 'led_status': 'green'}

=== FAN_INFO|PSU2.fan1 ===
{'presence': 'True', 'status': 'True', 'direction': 'N/A', 'speed': '50', 'speed_rpm': '9952', 'timestamp': '20260602 11:06:27', 'led_status': 'N/A', 'drawer_name': 'N/A', 'model': 'NXA-PAC-500W-PE', 'serial': 'LIT2709A9DV', 'speed_target': '50', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False'}

=== FAN_INFO|fantray2.fan1 ===
{'presence': 'True', 'drawer_name': 'fantray2', 'model': 'NXA-SFAN-35CFM-PE', 'serial': 'DCH2936TJ9625372537A0', 'status': 'True', 'direction': 'exhaust', 'speed': '49', 'speed_rpm': '12026', 'speed_target': '53', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False', 'timestamp': '20260602 11:06:27', 'led_status': 'green'}

=== FAN_INFO|fantray3.fan1 ===
{'presence': 'True', 'drawer_name': 'fantray3', 'model': 'NXA-SFAN-35CFM-PE', 'serial': 'DCH2936TJZK25372537A0', 'status': 'True', 'direction': 'exhaust', 'speed': '49', 'speed_rpm': '12162', 'speed_target': '53', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False', 'timestamp': '20260602 11:06:27', 'led_status': 'green'}

=== FAN_INFO|fantray4.fan2 ===
{'presence': 'True', 'drawer_name': 'fantray4', 'model': 'NXA-SFAN-35CFM-PE', 'serial': 'DCH2936TJZT25372537A0', 'status': 'True', 'direction': 'exhaust', 'speed': '48', 'speed_rpm': '10246', 'speed_target': '53', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False', 'timestamp': '20260602 11:06:27', 'led_status': 'green'}

=== FAN_INFO|fantray4.fan1 ===
{'presence': 'True', 'drawer_name': 'fantray4', 'model': 'NXA-SFAN-35CFM-PE', 'serial': 'DCH2936TJZT25372537A0', 'status': 'True', 'direction': 'exhaust', 'speed': '49', 'speed_rpm': '12053', 'speed_target': '53', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False', 'timestamp': '20260602 11:06:27', 'led_status': 'green'}

=== FAN_INFO|fantray1.fan2 ===
{'presence': 'True', 'drawer_name': 'fantray1', 'model': 'NXA-SFAN-35CFM-PE', 'serial': 'DCH2936TJEW25372537A0', 'status': 'True', 'direction': 'exhaust', 'speed': '49', 'speed_rpm': '10325', 'speed_target': '53', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False', 'timestamp': '20260602 11:06:27', 'led_status': 'green'}

=== FAN_INFO|fantray3.fan2 ===
{'presence': 'True', 'drawer_name': 'fantray3', 'model': 'NXA-SFAN-35CFM-PE', 'serial': 'DCH2936TJZK25372537A0', 'status': 'True', 'direction': 'exhaust', 'speed': '49', 'speed_rpm': '10285', 'speed_target': '53', 'is_under_speed': 'False', 'is_over_speed': 'False', 'is_replaceable': 'False', 'timestamp': '20260602 11:06:27', 'led_status': 'green'}

root@sonic:/home/admin# sonic-db-cli STATE_DB KEYS 'FAN_INFO|*' | sort | while read -r k; do printf '%-28s %s\n' "$k" "$(sonic-db-cli STATE_DB HGET "$k" speed_rpm)"; done
FAN_INFO|fantray1.fan1 12134
FAN_INFO|fantray1.fan2 10325
FAN_INFO|fantray2.fan1 12026
FAN_INFO|fantray2.fan2 10305
FAN_INFO|fantray3.fan1 12162
FAN_INFO|fantray3.fan2 10285
FAN_INFO|fantray4.fan1 12053
FAN_INFO|fantray4.fan2 10246
FAN_INFO|PSU1.fan1 10080
FAN_INFO|PSU2.fan1 9952
root@sonic:/home/admin#

Additional Information (Optional)

Related sonic-platform-common PR : sonic-net/sonic-platform-common#753

Signed-off-by: Sardar Shamsher Singh <meetshamsher@gmail.com>
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 3, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: meetshamsher / name: Sardar Shamsher Singh (5b9d843)

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Signed-off-by: Sardar Shamsher Singh <meetshamsher@gmail.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks!

---Powered by SONiC BuildBot

@meetshamsher

Copy link
Copy Markdown
Author

@maintainer Please add reviewer for this PR. It seems I don't have permission to add any reviewer.
Any platform side reviewer should be fine like keboliu, Junchao-Mellanox, lguohan, judyjoseph,...
Also if possible please enable write permission for me, so that i can add reviewer by myself.

@Verma-Anukul

Copy link
Copy Markdown

@YairRaviv @prgeor @keboliu @judyjoseph @micas-net @abelamit @vvolam

Please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants