Skip to content

[fpmsyncd]: coalesce ZMQ route sends behind a dedicated send thread #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepak-singhal0408 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[fpmsyncd]: coalesce ZMQ route sends behind a dedicated send thread #4855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdb32b6
[fpmsyncd]: coalesce ZMQ route sends behind a dedicated send thread
deepak-singhal0408 Jul 24, 2026
2def277
[fpmsyncd]: address review feedback on the route send coalescer
deepak-singhal0408 Sep 16, 2026
5fc7e22
address review: refuse the ZMQ route path conflict without aborting
deepak-singhal0408 Sep 18, 2026
919ac2e
address review: retire the coalescer at warm restart instead of refus…
deepak-singhal0408 Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fpmsyncd/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ else
DBGFLAGS = -g
endif

fpmsyncd_SOURCES = fpmsyncd.cpp fpmlink.cpp routesync.cpp $(top_srcdir)/warmrestart/warmRestartHelper.cpp \
fpmsyncd_SOURCES = fpmsyncd.cpp fpmlink.cpp routesync.cpp routesendcoalescer.cpp $(top_srcdir)/warmrestart/warmRestartHelper.cpp \
$(top_srcdir)/lib/orch_zmq_config.cpp

fpmsyncd_CFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_ASAN)
Expand Down
4 changes: 4 additions & 0 deletions fpmsyncd/fpmsyncd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ int main(int argc, char **argv)
bool warmStartEnabled = sync.getWarmStartHelper().checkAndStart();
if (warmStartEnabled)
{
// Reconcile writes the route tables directly on this thread.
sync.retireRouteCoalescer();

/* Obtain warm-restart timer defined for routing application */
time_t warmRestartIval = sync.getWarmStartHelper().getRestartTimer();
if (!warmRestartIval)
Expand Down Expand Up @@ -179,6 +182,7 @@ int main(int argc, char **argv)
}
else
{
sync.startRouteCoalescer();
sync.getWarmStartHelper().setState(WarmStart::WSDISABLED);
}

Expand Down
Loading
Loading