Validate createSwitchTimeout is a positive integer - #4898
Open
subharam-cisco wants to merge 1 commit into
Open
subharam-cisco wants to merge 1 commit into
subharam-cisco wants to merge 1 commit into
Conversation
Signed-off-by: Subhasri-Ramasamy <subharam@cisco.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
prhoskot
approved these changes
Sep 17, 2026
20 tasks
Collaborator
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
In orchagent main.cpp, -t is applied only when the parsed timeout is > 0. Invalid values are ignored, create_switch_timeout stays 0, and we log an error.
Why I did it
Review sonic-net/sonic-buildimage#28911 asked for validation of malformed/negative -t. createSwitchTimeout comes from per-HWSKU sai.profile; a bad value should not change switch-create behavior.
How I verified it
On Cisco, validated applying valid (150) and invalid (-1) values with syslog.
Details if related