Conversation
Temporarily set the LAG bridge port learning mode to DROP while an enabled member rejoins the LAG, then restore its configured mode. Verify transitions, retry recoverable failures, and retain failed work for explicit recovery. Add focused unit coverage for platform scope, retries, queue ownership, recovery, deletion, and per-LAG isolation. Signed-off-by: Zaahir Syed <44662240+zedzean@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Preserve and advance configuration retries while LAG deletion is blocked, let newer desired state replace obsolete retry targets, and synchronize desired mode after successful or terminal retry outcomes. Add deterministic regression coverage and remove the timing-sensitive queue coalescing test. Signed-off-by: Zaahir Syed <zaahir@cloudflare.com>
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
DROPwhile an enabled member rejoins the LAG, then restore the configured mode.broadcom/M2-W6520-48C8QCplatform.Why I did it
The affected SAI sequence enables learning on the physical port shortly before adding it back to the LAG. Traffic in that interval can generate FDB events for a bridge-port object that is immediately removed, leaving FDB state out of sync.
DROPprevents learning and unknown-source forwarding during that interval.Related reports:
Review status
This review-only draft is intentionally based on
d43da0182493e4d15ffac5f620ba03622e8b9b62to preserve exact source equivalence. It is 13 commits behind the current202511tip and is not intended to merge as-is.Validation
git diff --checkpasses.