Fix orchagent crash when destroying MuxAclHandler after AclOrch - #4909
Closed
harjotsinghpawra wants to merge 1 commit into
Closed
harjotsinghpawra wants to merge 1 commit into
harjotsinghpawra wants to merge 1 commit into
Conversation
Signed-off-by: Harjot Singh <harjotpawrawork@gmail.com>
harjotsinghpawra
requested review from
Ndancejic,
bingwang-ms and
prsunny
as code owners
September 21, 2026 17:36
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
|
Hi @harjotsinghpawra, there is a PR that addresses this already. Please help review/test to confirm this fix works for you. #4830 |
Collaborator
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
Collaborator
|
Closing this in favor of #4830 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes an orchagent crash during shutdown when
MuxAclHandlerobjects aredestroyed after
AclOrch.Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
MuxAclHandlerattempted to access the globalAclOrchinstance afterAclOrchhad already been destroyed. It could also throw when the expectedMUX ACL rule was unavailable during teardown.
How did you do it?
gAclOrchfromAclOrchdestructor.AclOrchis already destroyed.How did you verify/test it?
30c6ea5ff0e0:/sonic/src/sonic-swss/tests/mock_tests$ ./tests --gtest_filter='MuxRollbackTest.MuxTeardownAfterAclOrchDestructionIsSafe'
Running main() from ./googletest/src/gtest_main.cc
Note: Google Test filter = MuxRollbackTest.MuxTeardownAfterAclOrchDestructionIsSafe
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from MuxRollbackTest
[ RUN ] MuxRollbackTest.MuxTeardownAfterAclOrchDestructionIsSafe
[ OK ] MuxRollbackTest.MuxTeardownAfterAclOrchDestructionIsSafe (161 ms)
[----------] 1 test from MuxRollbackTest (161 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (161 ms total)
[ PASSED ] 1 test.
Any platform specific information?
N/A
Documentation