Repository navigation
fix(currency): add Nepalese rupee support - #675
Closed
SomSamantray wants to merge 1 commit into
Closed
SomSamantray wants to merge 1 commit into
SomSamantray wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution! Superseded by #679 , which moves to the Frankfurter v2 API and adds this currency along with many others. Closing in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups can now use Nepalese Rupees (NPR), with localized metadata in all 24 supported locales. Frankfurter v1 does not provide NPR rates, so cross-currency expense entries use the existing manual rate field. Verification passed: all 42 Jest suites (468 tests), TypeScript, Oxlint, Prettier, and the browser check selecting NPR on
/groups/create; the expense form route was not exercised because a database was unavailable. Fixes #438. AI disclosure: OpenAI Codex assisted with implementation and verification.