Repository navigation
Keep monthly recurrence on its original day of month - #676
Merged
Merged
Conversation
A series created on the 31st was clamped to 28 February and then stayed on the 28th. Store the anchor day on the recurring link and clamp only months that are too short.
quintushr
self-requested a review
October 13, 2026 17:05
Collaborator
|
Thanks @t0ma5 for the PR! I added some tests and added a guard against an infinite loop when the recurrence rule is NONE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anchorDayonRecurringExpenseLink. February still clamps to the 28th, and March returns to the 31st.Test plan
npm test -- src/lib/recurrence.test.ts20261012000000_add_recurring_anchor_day