Repository navigation
Ensure our custom fonts use 'Private Use Area' - #2449
Conversation
Otherwise a "better" alternative might be found in cosmic-text. While at it remove all the unused code paths.
b037e1f to
b8b25a8
Compare
|
This will mean that all copied icons will be (almost certainly) unknown glyphs when pasted. Might still be the most preferable path forward at the moment, but that's why actual glyphs were picked earlier. |
I believe that's what'll happen, we'll see a lovely ? bring pasted. Not sure if we can come up with a better solution, as the font cache will contain the system fonts that contain what unicode says should be colored emojis. So it's either private code points, colored emojis for some random bits, or revert to use first come first serve emoji selection |
|
From my viewpoint the ideal solution would be an ability to control font fallback, because we don't need fallback for the icon font period. But I don't think that's in the cards really, so as far as I can tell it's either garbage characters in pastes or switching to something that can't be copied as text like SVGs. My (weak) preference between the two is the former (i.e. how it's done in this PR), because switching to SVGs sounds like a lot of work for the resultant payoff. Just wanted to note that we are introducing another, minor regression by doing this. |
I agree, I kinda assumed specifying the font in the widget would only lookup in that one, but as meri pointed out we are showing colored robot, meaning it used the global font cache so it's our font + whatever it's loaded. I wish it was more restrictive, but unless we touch cosmic-text i don't see that happening (not offering as a volunteer :p) I didn't even think of switching to SVG, it's not straightforward. I think ? is a meh compromise, but the safest. |
Otherwise a "better" alternative might be found in cosmic-text.
While at it remove all the unused code paths.