Repository navigation
fix(history): retain maintenance writer lock through rollback - #1555
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelled archive and hourly backfill transactions can release the history writer mutex while Go is still rolling back the SQLite transaction. A live retry can then meet the old SQLite writer and fail with SQLITE_BUSY.
Keep the writer lock until rollback, connection cleanup and archive busy-timeout restoration finish. Reserve the connection in both hourly paths, as in #1552. Preparation still reads without holding the writer lock.
The regression delegates to real modernc SQLite, performs a real write, expires its context and delays the actual rollback. It checks all three maintenance paths and every pooled connection's restored busy timeout. The archive case fails on master before this fix. Twenty repeated regression runs and five race runs pass, including the existing archive contention and hourly backfill tests. Full
make verifypasses.This fixes another cancellation handoff race. It does not establish what caused the first five-second live write delay on v0.140.4-beta.1; #1554 remains a release blocker. This change needs a new beta and a fresh field trial.