Skip to content

Add traceID in error logging of stackit api calls - #1659

Merged
ske-prow[bot] merged 1 commit into
mainfrom
feature_traceid
Sep 16, 2026
Merged

Add traceID in error logging of stackit api calls#1659
ske-prow[bot] merged 1 commit into
mainfrom
feature_traceid

Conversation

@whtssub

@whtssub whtssub commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

How to categorize this PR?

/kind enhancement
/cc @stackitcloud/ske-infrastructure

What this PR does / why we need it:

This PR adds STACKIT trace IDs to API errors so they are available in controller and CSI logs during troubleshooting.

Ref: Log failed to ensure load balancer: [trace-id:1e7c1f4a6b48af6cbe944153d3125c91]: 400 Bad Request, status code 400, Body

@ske-prow
ske-prow Bot requested a review from a team September 14, 2026 14:50
@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2026
@aniruddha2000

aniruddha2000 commented Sep 15, 2026

Copy link
Copy Markdown
Member

/lgtm

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2026
@ske-prow

ske-prow Bot commented Sep 15, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: fac620d6f3aed9fab26e00aa34761263704506d0

breuerfelix
breuerfelix reviewed Sep 15, 2026
View reviewed changes
Comment thread pkg/stackit/client/helper_test.go Outdated
@ske-prow ske-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2026
@whtssub
whtssub force-pushed the feature_traceid branch 2 times, most recently from 5f883da to f095555 Compare September 16, 2026 08:48
@ske-prow ske-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2026
@whtssub
Add traceID in error logging of stackit api calls
032b4a3 
formatting fix

update helper func name to generic
@ske-prow

ske-prow Bot commented Sep 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breuerfelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@ske-prow

ske-prow Bot commented Sep 16, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 0a67dbc6595e5fb3cebd02624d3580f9a6366150

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026
@ske-prow
ske-prow Bot merged commit 4064647 into main Sep 16, 2026
3 checks passed
@ske-prow
ske-prow Bot deleted the feature_traceid branch September 16, 2026 12:37
@breuerfelix

breuerfelix commented Sep 16, 2026

Copy link
Copy Markdown
Member

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

@stackit-ske stackit-ske mentioned this pull request Sep 16, 2026
Merged
@stackit-ske

stackit-ske commented Sep 16, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1660

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske

stackit-ske commented Sep 16, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1661

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Sep 16, 2026
Merged
@stackit-ske

stackit-ske commented Sep 16, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1662

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Sep 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad left review comments
@breuerfelix breuerfelix breuerfelix approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@whtssub @aniruddha2000 @breuerfelix @stackit-ske @nschad