Allow connection_pool 3.x - #46
Open
yasaichi wants to merge 1 commit into
Open
Conversation
The existing 2.x-only constraint excludes a compatible major version even though the SDK's current API usage remains compatible with 3.x. Raise the minimum to the first release that can discard broken connections so the declared dependency also matches the current error path.
yasaichi
force-pushed
the
fix/allow-connection-pool-3
branch
from
September 3, 2026 12:42
00e42f5 to
f27639a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relax the
connection_pooldependency to allow 3.x releases.The current constraint (
~> 2.4,>= 2.4.1) excludesconnection_pool3.x even though the APIs used by Statsig remain compatible. It also prevents Statsig from being installed alongside libraries that require 3.x, including Sidekiq 8.1.Compatibility
Statsig currently uses:
ConnectionPool.new(size: ...)ConnectionPool#withConnectionPool#discard_current_connectionConnectionPool#shutdownThese APIs are compatible with Statsig's usage in both
connection_pool2.5.x and 3.x. Version 3 changed some positional arguments to keyword arguments, but Statsig does not use the affected forms and already passessize:as a keyword.Minimum version
Statsig currently declares support for
connection_pool2.4.1, but the SDK callsdiscard_current_connection, which was added in 2.5.4.The dependency is therefore changed to:
This keeps Ruby 2.5 compatibility through
connection_pool2.5.x while allowing Ruby 3.2+ applications to resolve 3.x.Validation
connection_pool2.5.4: test suite passed, excluding the credentialed liveCountryLookupTest#test_lookup.connection_pool3.0.2: test suite passed, excluding the credentialed liveCountryLookupTest#test_lookup.