Repository navigation
fix: rebuild verification service with Go 1.26.10 - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild the verifier with Go 1.26.10 to include the
crypto/x509certificate verification fix in GO-2026-6809. Pin the patch ingo.mod, use the official setup-go action to select it in CI, and alignDockerfile.localand development guidance. This service has no third-party Go module dependencies, so no x/net requirement is added.The production Dockerfile packages the
verificationbinary produced by CI'smake build; changing its Alpine runtime alone would not update Go. Document this build boundary and the amd64 solc requirement, and add a regression confirming that outbound HTTPS rejects an untrusted certificate. PR builds now skip registry login, image publication, and failure notifications while retaining test and image-build validation.Validation:
go mod tidy,go build ./...,go vet ./....go test -race -count=1 -v -skip '^(Test_compile|Test_MultifileCompile|Test_verificationHandler)$' ./...passes on macOS/arm64. These three tests execute downloaded amd64 solc binaries; this machine has no Rosetta support.go test -mod=mod -v ./...passes in Linux/amd64 with Go 1.26.10, Alpine, and gcompat, including actual solc compilation, the verification handler, and metadata/immutable/library/constructor compatibility regressions.make buildpasses in the same Linux/amd64 environment.go version -m verificationconfirms Go 1.26.10, linux/amd64, andCGO_ENABLED=0.git diff --checkpasses.The change prepares the production binary rebuild; it does not deploy the service.