Repository navigation
Frontend enhancement - #1964
Open
lebaudantoine wants to merge 2 commits into
Open
Frontend enhancement#1964lebaudantoine wants to merge 2 commits into
lebaudantoine wants to merge 2 commits into
Conversation
A floating reaction updated two states in requestAnimationFrame: the component was rendered again on every frame, about 180 times during the three seconds of its course, and moving it through its bottom offset laid it out each time. A burst of reactions multiplies this by the number of reactions on screen, during the call. Describe the same course with the Web Animations API instead: a rise at constant speed, with a fade out over the last 30 % of the course. The browser runs it, the component is rendered once, and only the transform and the opacity change.
useRoomData read the room with getQueryData during render, without subscribing. Consumers only updated because Conference observes the same query and re-renders its subtree, so a consumer behind a memoized component kept a stale value after a room settings or LiveKit metadata update. Subscribe to the query cache with useSyncExternalStore, filtered on the room entry. The hook stays a passive reader: it adds no observer, so it never fetches nor hands its own options to the query.
|
Collaborator
Author
[Medium impact] The PR appears safe to merge. Reviews (1) · Last reviewed commit: "🐛(frontend) subscribe useRoomData to th..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Minor improvements to ship small and frequently