Repository navigation
Conversation
The fallback language was hardcoded to French, so changing it required a code change. Read it from the VITE_DEFAULT_LANGUAGE build variable instead, keep French as the default, and ignore unsupported values. The Dockerfile forwards the variable to the frontend build, and the new setting is documented alongside the other build-time variables.
|
lebaudantoine
self-requested a review
November 18, 2026 11:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The fallback language was hardcoded to French, so self-hosters outside France had to patch the code to serve another default language. This change reads the fallback from the
VITE_DEFAULT_LANGUAGEbuild-time variable instead, keeps French as the default, and silently ignores unsupported values.What it does
src/frontend/src/i18n/init.ts: extract the supported languages into a sharedsupportedLngsconstant, read the fallback fromVITE_DEFAULT_LANGUAGEand validate it against that listsrc/frontend/Dockerfile: forward the new build argument to the frontend buildsrc/frontend/src/vite-env.d.ts: type the new variabledocs/self-hosting/configuration/theming.md: document the setting alongside the other build-time variablesHow to test
Then open the app in a browser whose language is not supported (e.g.
it-IT): the UI falls back to English instead of French.Checks run locally
npm run lint(eslint) — passnpm run check(prettier) — passnpm test(vitest, 41 tests) — passnpx tsc -b(typecheck) — pass