Skip to content

fix: label not showing in labels section #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sumn2u merged 3 commits into from
Apr 13, 2026
Merged

fix: label not showing in labels section #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc85150
fix: label not showing in labels section
sumn2u Apr 13, 2026
8c969df
fix null case issues
sumn2u Apr 13, 2026
74afbb5
Merge branch 'master' into label-info
sumn2u Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/src/ClassSelectionMenu/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export const ClassSelectionMenu = ({
regionColorList,
onSelectCls,
regions,
labels = []
}) => {
const getRegionsLabelCount = (label) => {
return regions?.filter((r) => r.cls === label).length
Expand Down Expand Up @@ -101,7 +102,7 @@ export const ClassSelectionMenu = ({
}}
/>
<Label className={classnames({ selected: label === selectedCls })}>
{capitalize(label)}
{capitalize(labels.find((l) => l.id === label)?.description || label)}
</Label>
<DashSep />
{getRegionsLabelCount(label) > 0 && (
Expand Down
3 changes: 2 additions & 1 deletion client/src/MainLayout/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ export const MainLayout = ({
const selectedImages = state.images.filter((image) => image.selected)
const hasRegions = state.images[state.selectedImage]?.regions?.length > 0
const disableRegion = !(state.images.length > 0 && state.regionClsList.length > 0); // enable save button for all cases
const labels = settings.settings.configuration.labels || [];
// hasRegions ? false : !state.hasNewChange

return (
<ThemeProvider theme={theme}>
<HotkeyDiv
Expand Down Expand Up @@ -391,6 +391,7 @@ export const MainLayout = ({
regionClsList={state.regionClsList}
regions={activeImage ? activeImage.regions : emptyArr}
regionColorList={state.regionColorList}
labels = { labels }
onSelectCls={action("SELECT_CLASSIFICATION", "cls")}
/>
),
Expand Down
Loading