Skip to content

chore: align pr templates - #1262

Open
ovitrif wants to merge 1 commit into
masterfrom
chore/pr-template-out-of-scope
Open

chore: align pr templates#1262
ovitrif wants to merge 1 commit into
masterfrom
chore/pr-template-out-of-scope

Conversation

@ovitrif

@ovitrif ovitrif commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Closes #1261

This PR gives the PR template one shape shared with bitkit-ios: scope stated in the description, one line of design guidance, and QA Notes with its subsections.

Description

  • Adds an #### Out of Scope subsection at the end of ### Description so reviewers read the author's non-goals instead of guessing them.
  • Requires the subsection for feat, fix, and refactor PRs; version bumps, changelog, and release PRs skip it, and other chores include it at the author's discretion.
  • Asks for one bullet per change under ### Description, what changed and why, so the intent of each change is on record.
  • Shortens the ### Design guidance to one line; the full rules stay in the /pr command.
  • Ships #### Manual Tests and #### Automated Checks under ### QA Notes, the structure the /pr command already generates.
  • Teaches the /pr command the scope rules so agent-authored PRs follow them.

Out of Scope

  • .agents/commands/release.md: version-bump PRs keep their fixed body; the scope subsection is for behaviour changes.
  • Back-filling the sections on PRs that are already open.
  • Enforcing the sections in CI: a later change once the team has used them for a while.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Manual Tests

  • 1. Open a new PR in the GitHub UI: the template shows #### Out of Scope at the end of ### Description, a one-line ### Design comment, and ### QA Notes with #### Manual Tests and #### Automated Checks.

Automated Checks

N/A — template and command text only.

@ovitrif ovitrif self-assigned this Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Regtest APK

Built from 9ce363a (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with a non-blocking inconsistency between the template and command guidance worth correcting.

Findings

  1. P2 PR guidance is inconsistent

Summary

  • Requests one what-and-why bullet for each described change.
  • Adds an Out of scope section for recording deliberate non-goals.
  • Defines which PR categories require or may omit that section.

Reviews (2) · Last reviewed commit: "chore: out of scope is required for feat..."

Comment thread .agents/commands/pr.md Outdated
@ovitrif ovitrif changed the title chore: PR template declares out-of-scope items and what-and-why bullets chore: require scope concerns in pr descriptions Sep 14, 2026
@ovitrif
ovitrif force-pushed the chore/pr-template-out-of-scope branch from 26da009 to 2ccd5c3 Compare September 14, 2026 15:42
@jvsena42

Copy link
Copy Markdown
Member

@ovitrif unverified commit

@ovitrif ovitrif changed the title chore: require scope concerns in pr descriptions chore: make scope explicit in prs Sep 14, 2026
@ovitrif

ovitrif commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

@greptileai review

Comment thread .github/pull_request_template.md Outdated
@ovitrif ovitrif changed the title chore: make scope explicit in prs chore: align pr templates Sep 14, 2026
@ovitrif
ovitrif force-pushed the chore/pr-template-out-of-scope branch from 921f954 to 9ce363a Compare September 14, 2026 17:35
@ovitrif
ovitrif force-pushed the chore/pr-template-out-of-scope branch from 9ce363a to fc1ec8a Compare September 14, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: align pr templates

2 participants