ci: make local e2e the merge gate - #1268
Conversation
Keep e2e-status as the required local check, move staging off PRs, and run migration on release-* with the same Slack summary as staging.
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
|
Pinning to main blocked testing slack_summary.py on a matching e2e-tests branch. Leave transfer_1 off staging until it is stable.
There was a problem hiding this comment.
Verdict: ✅ Approve
Review: diff 2 files.
Counterpart synonymdev/bitkit-ios#752: equivalent.
Findings:
N/A
Audit:
Skipped - no security surface in the diff (score 0, threshold 3).
Reviewed by gpt-5.6-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer test · retest · audit (author or owner)
Related to synonymdev/bitkit-e2e-tests#221 (PR B)
This PR:
e2e-statusis local-onlye2e-staging.ymlon schedule and dispatch (no PR trigger)release-*PRs and posts the same Slack summary as stagingDescription
Staging stays off the merge gate. Feature PRs no longer wait on stag0. Local
lnurl_transfergrep is@lnurl|@transfer_2. Staging shards stay@multi_address_2,@pubky,@hardware_wallet,@transfer_max(@transfer_1later). Slack checkout uses the resolved e2e-tests branch so a same-named branch can testslack_summary.py.Migration:
pull_requestruns only when head or base starts withrelease-. Slack posts on schedule and on dispatch whenpost_to_slackis true, usingSLACK_WEBHOOK_URL_STAGING.Design
N/A — no UI changes.
Preview
N/A
QA Notes
Manual Tests
N/A
Automated Checks
e2e-statuswithout staging jobs.gh workflow run e2e-staging.ymlstill works; migration on arelease-*PR should run; nightly/dispatch withpost_to_slackposts to#bitkit-staging-nightly.