Skip to content

ci: make local e2e the merge gate - #1268

Merged
ovitrif merged 2 commits into
masterfrom
ci/e2e-local-merge-gate
Sep 16, 2026
Merged

ovitrif merged 2 commits into
masterfrom
ci/e2e-local-merge-gate

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Related to synonymdev/bitkit-e2e-tests#221 (PR B)

This PR:

  1. Drops staging jobs from the local merge-gate workflow so required e2e-status is local-only
  2. Keeps e2e-staging.yml on schedule and dispatch (no PR trigger)
  3. Runs migration on release-* PRs and posts the same Slack summary as staging

Description

Staging stays off the merge gate. Feature PRs no longer wait on stag0. Local lnurl_transfer grep is @lnurl|@transfer_2. Staging shards stay @multi_address_2, @pubky, @hardware_wallet, @transfer_max (@transfer_1 later). Slack checkout uses the resolved e2e-tests branch so a same-named branch can test slack_summary.py.

Migration: pull_request runs only when head or base starts with release-. Slack posts on schedule and on dispatch when post_to_slack is true, using SLACK_WEBHOOK_URL_STAGING.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Manual Tests

N/A

Automated Checks

  • Workflow YAML only. After merge: a feature PR should go green on e2e-status without staging jobs.
  • After merge: gh workflow run e2e-staging.yml still works; migration on a release-* PR should run; nightly/dispatch with post_to_slack posts to #bitkit-staging-nightly.

Keep e2e-status as the required local check, move staging off PRs, and
run migration on release-* with the same Slack summary as staging.
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Regtest APK

Built from 52a432b (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, although the existing non-blocking concern about executing mutable external references with the Slack webhook remains unresolved.

Findings

  1. P2 Security Mutable Code Receives Secret

Summary

This PR makes local E2E tests the pull-request merge gate and expands migration workflow triggering and reporting.

  • Removes staging build and test jobs from the local E2E workflow and makes e2e-status depend only on local shards.
  • Narrows the local transfer shard to @transfer_2.
  • Runs migration jobs for non-draft pull requests whose head or base branch begins with release-.
  • Adds scheduled and opt-in dispatch Slack summaries using the resolved E2E test branch.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    PR[Pull request] --> Local[Local E2E shards]
    Local --> Gate[e2e-status merge gate]

    Release[release-* pull request] --> Migration[Migration E2E]
    Schedule[Scheduled run] --> Migration
    Dispatch[Manual dispatch] --> Migration

    Schedule --> Report[Slack migration summary]
    Dispatch -->|post_to_slack=true| Report
    Migration --> Report
Loading

Reviews (2) · Last reviewed commit: "ci: checkout slack script from resolved ..."

Comment thread .github/workflows/e2e_migration.yml Outdated
Pinning to main blocked testing slack_summary.py on a matching
e2e-tests branch. Leave transfer_1 off staging until it is stable.
@piotr-iohk
piotr-iohk marked this pull request as draft September 15, 2026 12:50
@piotr-iohk
piotr-iohk marked this pull request as ready for review September 16, 2026 15:36

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve


Review: diff 2 files.
Counterpart synonymdev/bitkit-ios#752: equivalent.

Findings:
N/A

Audit:
Skipped - no security surface in the diff (score 0, threshold 3).


Reviewed by gpt-5.6-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer test · retest · audit (author or owner)

@ovitrif
ovitrif merged commit 1a9f2c9 into master Sep 16, 2026
37 checks passed
@ovitrif
ovitrif deleted the ci/e2e-local-merge-gate branch September 16, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants