Skip to content

bug: activity search placeholder is hard-coded in english #945

Closed
#938
Closed
bug: activity search placeholder is hard-coded in english#945
#938
Assignees
ovitrif
Milestone
3.0.0

Description

@jvsena42
jvsena42
opened on Oct 15, 2026

What happened?

The Activity search field placeholder is a hard-coded English string, so it shows "Search" in every language:

Bitkit/Components/Activity/ActivityListFilter.swift:14

TextField("Search", text: $viewModel.searchText, ...)

Expected behavior

The placeholder comes from Localizable.strings like the rest of the screen.

Found while checking translations on #938.

Activity

  1. ovitrif
    added this to the 3.0.0 milestone on Oct 15, 2026
  2. ovitrif
    self-assigned this
    on Oct 15, 2026
  3. ovitrif
    added a parent issue on Oct 15, 2026

  4. ovitrif commented on Oct 15, 2026

    @ovitrif
    ovitrif
    on Oct 15, 2026
    Collaborator

    Fixed in 407e899 on #938, which closes this issue. The activity search field in ActivityListFilter.swift now uses t("common__search"), the same call and TextField initializer as LocalCurrencySettingsView and ContactsListView. common__search already exists in English and is translated in all 14 locales, so no new key was needed. The Xcode build runs in CI on that PR.

  5. ovitrif
    closed this as completedin #938on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions