Skip to content

refactor(repo): delete the hello seed package - #43

Merged
kiro-systemf[bot] merged 58 commits into
mainfrom
lake1/delete-hello
Oct 7, 2026
Merged

kiro-systemf[bot] merged 58 commits into
mainfrom
lake1/delete-hello

Conversation

@systemfsoftware-maker

@systemfsoftware-maker systemfsoftware-maker commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Lake 1, U9 — stacked on #42. Operator approval: Kiro, 2026-10-05 (release job shape: keep tags + GitHub Releases, drop npm).

  • packages/starter/** deleted (R121). packages/* stays a workspace glob for adopters.
  • README.md: the workspace tree and package list now name apps/site and apps/site-e2e; "Claim the Package" and the tsdown row are gone; the Changesets row no longer mentions npm OIDC.
  • pnpm-workspace.yaml: rimraf and tsdown leave the catalog (no manifest uses them); lockfile regenerated.
  • Release pipeline without npm:
    • release.yml: the publish · oidc · tag job becomes release · tag on small — capture, assert release notes, tag, GitHub Releases. No build, no id-token: write, no pnpm publish.
    • scripts/lib/cycle.ts: a version is owed when git tag --list <name>@v<version> is empty. isPublished/unpublishedOf are gone.
    • plan-release.ts: phase publish → release. tag-released-packages.ts: --publish/--unpublished removed.
    • No script's --allow-net names registry.npmjs.org. .changeset/README.md and the Release PR body describe tags + GitHub Releases.
  • After this PR no workspace package is public, so the pipeline tags nothing until one exists. U11b replaces these scripts with a caller of pnpm-release-management's reusable release workflow.

QA

$ git grep -nI -e '@TODO/starter' -e 'packages/starter' -e 'hello.integration' -- . ':!*.lock' ':!docs/brainstorms' ':!docs/plans'
(exit 1)
$ git grep -nIE 'npmjs|OIDC|oidc|provenance|id-token|unpublished|--publish' -- . ':!*.lock' ':!docs/brainstorms' ':!docs/plans' ':!docs/solutions' ':!repos'
(exit 1)
# throwaway repo: one public package @x/a@1.0.0
--- untagged
plan-release: pending_intents=0 this_cycle=1 -> phase=release
would tag @x/a@v1.0.0
--- after `git tag @x/a@v1.0.0`
plan-release: pending_intents=0 this_cycle=0 -> phase=none
dry run: 0 tag(s)
# this repo
$ ./scripts/plan-release.ts
plan-release: pending_intents=0 this_cycle=0 -> phase=none
$ ./scripts/create-github-releases.ts --assert --captured empty.json   # no registry.npmjs.org permission
no this-cycle releases — empty captured set
$ nix develop --command actionlint .github/workflows/*.yml
actionlint=0
$ pnpm check:ci
check=0
$ pnpm journeys
journeys=0

Peer warnings (hono from @alchemy.run/frontend-frameworks, typescript from capnp-es) predate this PR: the same two appear at #42's head.

@systemfsoftware-maker
systemfsoftware-maker added this pull request to stack #34 October 5, 2026 20:59
systemfsoftware-maker added a commit that referenced this pull request Oct 6, 2026
…and QA evidence

Findings for #43, #45, #49, #50 and #51 from ce-code-review (8 lenses, validator), the verifier's probes of every P0/P1 including those the merge dropped, and the real-browser, local-Tempo and live-preview QA. Nothing applied; each finding waits for a ruling
@systemfsoftware-maker
systemfsoftware-maker removed this pull request from stack #34 October 6, 2026 16:04
@systemfsoftware-maker
systemfsoftware-maker added this pull request to stack #54 October 6, 2026 19:52
@systemfsoftware-maker
systemfsoftware-maker removed this pull request from stack #54 October 6, 2026 21:56
@systemfsoftware-maker
systemfsoftware-maker added this pull request to stack #59 October 6, 2026 21:57
@systemfsoftware-maker
systemfsoftware-maker removed this pull request from stack #59 October 6, 2026 22:13
@systemfsoftware-maker
systemfsoftware-maker added this pull request to stack #61 October 6, 2026 22:13
Conductor ruling, cycle 61, F4: inside the sandbox's network namespace the guard can never fire, and that isolation already keeps a stale host server from answering the journeys
Conductor ruling, cycle 61, F6: the test task's outputLogs is new-only, so CI logs show each executed test
Conductor ruling, cycle 62: the same bump pnpm-release-management#31 took. effect and every @effect/* stay at 4.0.1; none resolves lower. tsgo 0.50.0 reports nothing new: typecheck and lint are clean uncached. @systemfsoftware/oxlint-config-recommended 4.0.0 still pulls its own @effect/tsgo 0.45.0
# Conflicts:
#	pnpm-lock.yaml
#	pnpm-workspace.yaml
@kiro-systemf
kiro-systemf Bot removed this pull request from stack #61 October 7, 2026 15:41
…go to 0.51.0

Conductor ruling, cycle 67: prm main (#9, ca932ae) now requires versioning.strategy. The starter versions each workspace package from .changeset intents, so it takes changesets. Followed prm README: "`changesets` versioning drives the changesets libraries per package: the assembled release plan decides each member's bump, workspace dependents move with it, and the consumed intents are removed". No other field is required under that strategy. @effect/tsgo 0.50.0 -> 0.51.0 (npm latest, 2026-10-07T09:37Z); effect stays 4.0.1. Uncached check:ci and journeys pass with no new diagnostics
@kiro-systemf
kiro-systemf Bot changed the base branch from lake1/stack-ci to main October 7, 2026 16:34

@kiro-systemf kiro-systemf Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conductor verdict: 8/8 green on 91b3707, tree == reviewed 380bde4, 0 threads, hunt clean.

@kiro-systemf
kiro-systemf Bot merged commit d18ae43 into main Oct 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant