Repository navigation
feat(repo): preview every pull request and deploy production after the release gate - #51
Merged
Merged
Conversation
systemfsoftware-maker
added this pull request to stack #34
October 6, 2026 06:50
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 07:00
42daf85 to
da52978
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
2 times, most recently
from
October 6, 2026 07:09
df94d42 to
f1c3dca
Compare
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 07:09
898780d to
d6b2448
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 07:09
f1c3dca to
c62be46
Compare
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 07:09
d6b2448 to
37d80bd
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
2 times, most recently
from
October 6, 2026 07:16
2adfaea to
c62be46
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 08:38
bf7d5c2 to
5601df1
Compare
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 08:38
37d80bd to
0d4c98d
Compare
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 08:49
0d4c98d to
cd8afa1
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 08:49
5601df1 to
a74911e
Compare
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 12:17
cd8afa1 to
b6d0f68
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 12:17
a74911e to
0729813
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 16:00
0729813 to
c844f3a
Compare
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 16:00
b6d0f68 to
a10eba6
Compare
systemfsoftware-maker
removed this pull request from stack #34
October 6, 2026 16:04
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 16:15
a10eba6 to
6363c0d
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 16:15
c844f3a to
21cd2c7
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 16:31
21cd2c7 to
ee6cce4
Compare
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 16:31
6363c0d to
e1cd31c
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 17:00
ee6cce4 to
96f34bf
Compare
systemfsoftware-maker
force-pushed
the
lake1/deploy
branch
from
October 6, 2026 17:28
c62f54b to
d96b565
Compare
systemfsoftware-maker
force-pushed
the
lake1/previews
branch
from
October 6, 2026 17:29
96f34bf to
685e400
Compare
…anagement input Conductor ruling, cycle 71: since pnpm-release-management#11 (aa712d9), devshell: true runs nix develop --command sandbox -- changeset-management check with the release-tools in the caller's dev shell. The pinned input (5eb4c5d, followed from systemfsoftware main) already exports packages.<system>.release-tools, so the lock does not move
Conductor rulings, cycles 74 and 77: pnpm-release-management main 537d17c carries #14, #20 (the consumer store) and #24 (the linked-worktree change), so the starter's own copy of that change (nix/patches/sandbox-linked-worktree-git.patch) and its applyPatches wiring go. pnpm-release-management becomes a direct input on main, locked to 537d17c; systemfsoftware follows it, and its nixpkgs, comment-checker and importPnpmLock follow the starter's
starter-verify c73: withoutSandboxOnPath removed only the first directory that held sandbox, so with two launchers on PATH the hooks still found one and the refusal step failed falsely. It now drops every PATH entry that provides sandbox. Two launchers on PATH: the old helper fails the step, the new one passes; with the hooks' sandbox prefix stripped, the step fails
Conductor ruling, cycle 83: stryker-js-effect main f06f244 (#196) publishes its 17 members as tarballs with an index.json. The flake adds it as an input (locked to f06f244, following the starter's nixpkgs, comment-checker, importPnpmLock, pnpm-release-management and systemfsoftware), and .sfs-deps now holds both flakes' tarballs with one merged index.json. Every @systemfsoftware/stryker-* member is a file:.sfs-deps catalog entry with an override, the same mechanism as the systemfsoftware packages, plus one for the stryker-js-vm-runner npm alias that stryker-js 17.0.2 declares, so check:sfs-sources passes with no npm-sourced @systemfsoftware/* package
Contributor
There was a problem hiding this comment.
Verified: all checks green on da833eb, 0 threads, hunt clean.
systemfsoftware-maker
added a commit
that referenced
this pull request
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lake 1, U13, stacked on #50. Trimmed per Kiro's 2026-10-06 ruling: previews and a plain production deploy stay, guarded by
is_template; no Workers Issues automation, no version check or rollback, no Alchemy patch..github/workflows/previews.yml: a same-repo pull request in an adopter's copy deploys as itspr-<N>stage, gets its URL in one PR comment (edited on every push), and is destroyed when the PR closes. Fork PRs and the template itself get none..github/workflows/release-gate.ymlgainsdeploy · production: onmain, once the plan passed and the mutation job passed (every shard at break 100) or was skipped (no decisions to mutate, ci(ci): move mutation to a release gate on main #35),pnpm run deploy(tovars.SITE_DOMAINwhen that repository variable is set). A failed plan, a failed shard or a cancelled run never deploys..github/actions/cloudflare-secretsfails both jobs early, naming any missing secret.bin/cloud(deploy, destroy, state reads).AGENTS.mdstates that boundary as a rule.Alchemy patch: dropped. Deploy does not need it; its two hunks served only the
CloudflareTracersubpath (traces, #45) and the Workers Issues reconcile (trimmed here).Gate at
bcd99ef, before the restack onto #35's no-decisions rule (the deployed-journeys lines it carried are gone with F11)Not exercised here: a preview or production run, which needs an adopter's copy and its secrets.
Restack, 2026-10-06
Rebased onto #35's no-decisions rule. The deploy job's condition (
needs: [plan, mutation],!cancelled() && plan == success && mutation in {success, skipped} && !is_template) is the only change in this layer's tree;actionlintpasses on it.Cycle 35 (Kiro rulings on starter-verify's review)
93b958c): the deployed-site journeys are not in the spec, so they come out:bin/journeys-deployed, thejourneys:deployedscript, the journeys and artifact-upload steps inpreviews.ymlandrelease-gate.yml(the uploads carried only what those journeys wrote), the README line, and theAGENTS.mdclause, whose rule keeps a grounded wrong/right pair. Deploy, the preview comment and destroy are unchanged; the preview job is namedpreview · deploy. No reference tojourneys:deployedorjourneys-deployedremains on this branch.Gate after the cycle 52 restack (Linux only)
Gate at
c7b0037, clean worktree, Linux, sandboxed:CI run 37573586754 on
c7b0037: 6 of 7 jobs pass (format, lint, typecheck, test, dist, journeys);check (sfs-sources)fails, the same red as the local gate above.Gate after cycle 83 (every
@systemfsoftware/*package from our flakes, #52)Gate at
2a15ef0, clean worktree, Linux, sandboxed:CI run 37675953316 on
2a15ef0: all 7 jobs pass,check (sfs-sources)included. Theexit 1gates above are from before the stryker packages came from the stryker-js-effect flake.