Skip to content

[Feature Request] Best practice fix for Temporalio.Workflows.Semaphore.WaitAsync ContinueWith #601

Description

@cretz

Describe the solution you'd like

We're improperly using ContinueWith in Temporalio.Workflows.Semaphore.WaitAsync as if it were a "map success", which could cause us to swallow exceptions (as we did for #599). However, there are basically no fallible situations in the task being ContinueWith'd today, so this is not an urgent bug.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions