Conversation
…ame row The branch for image cells in TerminalRenderer.render() reset the pending text run without drawing it, so text before an image on the same row was not drawn. It also started the next run one column late. Draw the pending run first, and start the next run at the cell after the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #2973, cc @MatanZ.
In
TerminalRenderer.render(), the branch for image cells discarded the pending text run, so text before an image on the same row was never drawn.The change has four parts.
columnis already incremented at that point, socolumn + 1started it one column late.currentCharIndexbefore it recordslastRunStartIndex. The start index of the next run then matches its start column.lastRunInsideSelectionwith the other run state.Testing
Tested on a Samsung SM-X806B with Android 16. The APK is a debug build of this branch (8629e63 plus this commit) from GitHub Actions on my fork. Only
versionCodewas changed for it, so that it installs over my existing build.I ran:
Before (master):

LEFTis drawn for a moment and disappears when the image appears.After (this branch):

LEFTstays on screen, with the image to its right at the same position as before.