Repository navigation
Fix 500 when setting a violation section that does not exist - #279
Merged
Merged
Conversation
PUT /violations/:id/section with 999999999 returned 500: SectionsRepository findOneOrFail only checked for 9 digits, then SECTION_SEGMENT_BREAKDOWN did not match and reading .groups of null threw a TypeError. It now throws EntityNotFoundError, so the endpoint answers 409 VIOLATION_SECTION_NOT_FOUND („Секция с този номер не съществува“) and GET /sections/:id answers 404. A section that is not 9 digits gets a 400 VIOLATION_SECTION_INVALID_FORMAT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUT /violations/:id/sectionwith999999999returned 500. Cause:SectionsRepository.findOneOrFailonly checked for 9 digits;999999999has no valid election region, soSECTION_SEGMENT_BREAKDOWNdidn't match andmatches.groupsthrew a TypeError.findOneOrFailnow throwsEntityNotFoundErrorfor ids that don't match the section pattern → the endpoint returns 409VIOLATION_SECTION_NOT_FOUND(„Секция с този номер не съществува“ / „There is no section with this number“);GET /sections/999999999becomes a 404 instead of a 500 too.VIOLATION_SECTION_INVALID_FORMAT(„Номерът на секцията трябва да е точно 9 цифри“).