You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add PTHREAD_STACK_MIN fallback to macOS builds - #5
PTHREAD_STACK_MIN is part of the POSIX threading standard, but is optional on macOS. Because this constant isn't defined, the compiler sees an undeclared identifier and throws an error.
This change adds a PTHREAD_STACK_MIN conditional to tdsh_posix.c so that macOS builds succeed.
Thanks for the fix, and welcome! It builds cleanly on Linux and all host tests pass.
One small request since you can test on macOS: POSIX defines PTHREAD_STACK_MIN in <limits.h>, which tdsh_posix.c never includes (on Linux it only arrives through <pthread.h>). Could you add #include <limits.h> with the other system headers and check whether macOS then defines it? If it does, it'll use the real value (16 KB on Apple Silicon, I believe), and your fallback can stay as a safety net for systems that still lack it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTHREAD_STACK_MIN is part of the POSIX threading standard, but is optional on macOS. Because this constant isn't defined, the compiler sees an undeclared identifier and throws an error.
This change adds a PTHREAD_STACK_MIN conditional to tdsh_posix.c so that macOS builds succeed.