Repository navigation
browser: Honor filtered Puppeteer launch arguments - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FILTER_CHROME_ARGS=--disable-dev-shm-usageremoves Steel’s copy of the flag, but Puppeteer appends the same flag from its defaults. Chromium therefore continues using/tmpeven when the deployment supplies a larger/dev/shm. Apply the configured filter to Puppeteer’s default arguments as well as Steel’s arguments.Validation: a real-Chrome regression fails before the fix and passes afterward, inspecting the running process arguments while preserving unrelated defaults. All 18 launch/mobile/validation tests, the API build, and changed-file formatting checks pass.
The companion mass-modules template mounts a bounded 2 GiB memory-backed volume at
/dev/shm, selects Chromium’s binary directly to avoid Debian’s wrapper adding its own shared-memory fallback, and setsFILTER_CHROME_ARGS. Deploy the rebuilt browser image with that template.