Skip to content

feat(credential-form): fill snapshot-selected fields without submitting - #17

Merged
latter-bolden merged 1 commit into
reid/cred-storefrom
brian/tlon-6858-agent-driven-secure-entry
Oct 21, 2026
Merged

latter-bolden merged 1 commit into
reid/cred-storefrom
brian/tlon-6858-agent-driven-secure-entry

Conversation

@latter-bolden

@latter-bolden latter-bolden commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Description

Make secure credential entry use one fill-only contract: bind fields selected from a fresh browser snapshot, fill only those controls through the browser input pipeline, and leave every click or submission to the agent.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Code refactoring
  • Test addition/update

Related Issues

Related to TLON-6858.

Changes Made

  • Rebind snapshot-selected controls against the original live document and reject stale or ambiguous selections.
  • Add a trusted credential writer path without falling back to ordinary DOM assignment after writer failures.
  • Accept the legacy submit input for compatibility while always returning submitted: false.
  • Close failed viewer handoff rounds promptly and preserve the fill-only contract through the viewer gateway.

Testing

  • API TypeScript build passes.
  • 100 Chrome-backed credential-form tests pass.
  • 46 session-viewer tests pass.
  • Changed files pass Prettier.

Documentation

Public behavior is described through the API types, comments, and companion MCP tool guidance.

Code Quality

  • Code follows the project's style guidelines.
  • Self-review completed.
  • New behavior has focused regression coverage.

Breaking Changes

None. The legacy submit field remains accepted, but secure entry deliberately ignores it so filling never authorizes submission.

Additional Notes

Companion MCP PR: tloncorp/steel-mcp-server#8

Secure entry binds snapshot-selected fields to concrete controls and fills them through the browser input pipeline. The legacy submit flag remains accepted for compatibility but is ignored, so agents inspect the filled page and choose the next action. The viewer gateway forwards fill-only requests and reports discovery failures without waiting for capability expiry.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Oct 21, 2026

Copy link
Copy Markdown

TLON-6858

@latter-bolden
latter-bolden merged commit 76f1ef9 into reid/cred-store Oct 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants