Repository navigation
feat: error boundary in render() — never-blank guarantee - #49
Merged
Merged
Conversation
Layout and SVG rendering are now wrapped in a try/catch; an internal throw renders an error-state SVG and returns the caught error on RenderResult instead of leaving the target blank. Closes #11. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeLayout+renderSVGinrender()with a try/catch: an internal throw now renders a minimal error-state SVG ("Diagram failed to render" + message) instead of propagating and leaving the target blank. Closes feat: error boundary in render() — never-blank guarantee #11.error?: ErrortoRenderResultso callers can detect it.strict: truebehavior is unchanged — parse errors still throwFloraParseErrorbefore rendering starts.Test plan
computeLayoutto throw and asserts an SVG is still attached,result.erroris returned, and warnings survivetsc --noEmitclean; site builds🤖 Generated with Claude Code