fix(detectors/ngrok): match API keys that do not start with 2 - #5152
Open
mattbrady-1 wants to merge 3 commits into
Open
fix(detectors/ngrok): match API keys that do not start with 2#5152mattbrady-1 wants to merge 3 commits into
mattbrady-1 wants to merge 3 commits into
Conversation
The ngrok bearer token pattern is 27 alphanumerics, an underscore, and 21 alphanumerics. Requiring a leading 2 missed valid API keys and ak_ resource IDs were never secrets. Co-authored-by: Cursor <cursoragent@cursor.com>
Corpora Test ResultsScans a corpus of real-world public code against only the detectors changed in this PR, then compares unique match counts between the PR build and the main baseline to catch regex regressions. Verification is disabled — each detector's regex is measured independently. 0 new · 1 clean | Scoped to:
|
The prefix broadening accidentally allowed any alphanumeric suffix start, which would increase false positives. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3fa132a. Configure here.
Real authtokens verified against the ngrok API can have 20-char and letter-leading suffixes, so the digit-leading 21-char suffix constraint drops valid secrets. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
2[a-zA-Z0-9]{26}to[a-zA-Z0-9]{27}so valid bearer tokens are detected regardless of first character.ERR_NGROK_206) exist with 20-char and letter-leading suffixes, so a digit-leading 21-char suffix constraint drops valid secrets.2, letter-leading and 20-char suffixes, andak_resource IDs, which are not secrets.Test plan
go test ./pkg/detectors/ngrok/ -run TestNgrok_PatternMade with Cursor