Skip to content

fix: keep Claude plugins a project enables natively - #23

Merged
zbeyens merged 1 commit into
mainfrom
fix/native-claude-plugins
Sep 29, 2026
Merged

zbeyens merged 1 commit into
mainfrom
fix/native-claude-plugins

Conversation

@zbeyens

@zbeyens zbeyens commented Sep 29, 2026

Copy link
Copy Markdown
Member

Why

skiller apply treated every enabledPlugins entry in .claude/settings.json as legacy plugin-sync state and refused to run. A project that shares a Claude Code plugin with its team declares it there, next to extraKnownMarketplaces. Skiller never wrote that entry, but apply still blocked on it, so any repo whose postinstall runs skiller apply failed bun install for everyone.

What changes

  • assertNoLegacyClaudePluginState refuses only when skiller's own manifest (.agents/.skiller.json or .claude/.skiller.json) still lists plugin entries. That manifest is the record of what plugin sync used to manage.
  • apply leaves enabledPlugins and extraKnownMarketplaces untouched.
  • docs/skills.md and docs/troubleshooting.md describe the current behavior; they still documented the removed plugin sync.

Tests

  • The integration test that expected a refusal for native enabledPlugins now asserts that apply succeeds for codex and claude-code and keeps both settings keys unchanged. It failed before the fix with the refusal.
  • The two manifest cases still reject with the migration guidance.
  • npm run lint, npm test (808 passed), npm run build pass locally.

🤖 Generated with Claude Code

skiller apply treated every enabledPlugins entry in .claude/settings.json
as legacy plugin-sync state and refused. A project that declares a plugin
with extraKnownMarketplaces owns that entry; skiller never wrote it. Apply
now refuses only on plugin entries in skiller's own manifest, and leaves
the settings as they are.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@changeset-bot

changeset-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 50f68fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skiller Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zbeyens
zbeyens merged commit 8b85b7b into main Sep 29, 2026
1 check passed
@zbeyens
zbeyens deleted the fix/native-claude-plugins branch September 29, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant