Repository navigation
fix: keep Claude plugins a project enables natively - #23
Merged
Merged
Conversation
skiller apply treated every enabledPlugins entry in .claude/settings.json as legacy plugin-sync state and refused. A project that declares a plugin with extraKnownMarketplaces owns that entry; skiller never wrote it. Apply now refuses only on plugin entries in skiller's own manifest, and leaves the settings as they are. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🦋 Changeset detectedLatest commit: 50f68fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
skiller applytreated everyenabledPluginsentry in.claude/settings.jsonas legacy plugin-sync state and refused to run. A project that shares a Claude Code plugin with its team declares it there, next toextraKnownMarketplaces. Skiller never wrote that entry, but apply still blocked on it, so any repo whose postinstall runsskiller applyfailedbun installfor everyone.What changes
assertNoLegacyClaudePluginStaterefuses only when skiller's own manifest (.agents/.skiller.jsonor.claude/.skiller.json) still lists plugin entries. That manifest is the record of what plugin sync used to manage.applyleavesenabledPluginsandextraKnownMarketplacesuntouched.docs/skills.mdanddocs/troubleshooting.mddescribe the current behavior; they still documented the removed plugin sync.Tests
enabledPluginsnow asserts that apply succeeds forcodexandclaude-codeand keeps both settings keys unchanged. It failed before the fix with the refusal.npm run lint,npm test(808 passed),npm run buildpass locally.🤖 Generated with Claude Code