Repository navigation
Add a recording check to device alert settings - #323
Merged
Merged
Conversation
notificationSettings.devices.recordingCheck alerts when a selected camera that records continuously is online but has not uploaded a recording for recordingCheckHours (1 to 72, 0 means 2), and again once it records. It shares the device alert channels, cameras and grouping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two fields to
notificationSettings.devices:recordingCheck(bool): alert when a selected camera that records continuously is online but has not uploaded a recording forrecordingCheckHours, and again once it records. Cameras that only record on motion are not checked.recordingCheckHours(int32): 1 to 72 hours. 0 means unset; the monitor uses 2.The check reuses the device alert channels, cameras and
groupNotifications. Generated properties are updated. The round-trip test covers BSON, JSON and documents without the fields.Consumers
Tag after merge. Then:
GET /notificationsettingsreturns the fields.🤖 Generated with Claude Code