Repository navigation
Fix durable RabbitMQ retry publication - #21
Merged
Merged
Conversation
Publish retry and dead-letter messages synchronously and return failures before acknowledging the original delivery. Add broker-free regression coverage for success, failure, and retry exhaustion.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a reliability gap in the RabbitMQ retry pipeline where a message could be acknowledged before its retry publication had actually succeeded.
PipelineRetrynow performs a synchronous republish to the consumer queue and only acknowledges the original delivery after the publish completes successfully. If the publish fails, the consumer exits without acknowledging the message, allowing RabbitMQ redelivery and reconnect logic to recover it instead of silently losing the payload.The retry flow was also simplified to use the same reconnect-aware publish path used elsewhere in the queue implementation, improving consistency and resilience during broker interruptions.
In addition, retries and dead-letter handling are now fully covered by unit tests, including:
The README was updated to document the stronger delivery guarantees and retry behavior.