Repository navigation
Log RabbitMQ dead-letter decisions before publication - #29
Merged
Merged
Conversation
Accept an optional service logger and emit one structured warning before new DLQ publication, using existing reason codes and already-decoded event correlation. Preserve payloads, retries, settlement and public handler APIs; no extra decoding, observers, or background workers are required. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional RabbitOptions.SetLogger using the existing service logrus logger and models/pkg/api envelope. Emit one WARN dead_letter_requested before attempting a new DLQ publication.
Reuse the existing DeadLetterReason catalog: malformed, handler_error, retry_exhausted, publish_failed and unspecified. Include source/DLQ queue, attempts and already-decoded event traceId/media filename where available.
Validation
Supersedes the diagnostic infrastructure approach in closed uug-ai/hub-pipeline-sequence#92. Existing optional DLQ observer remains available but is not needed or enabled by this approach.