Repository navigation
Ev cleanup retire vsettings - #296
Merged
Merged
Conversation
The in-game config screen (Alt+C) now owns settings editing, reading and writing the split JSON config directly, so the standalone Kivy app is superseded. Remove it and everything that only existed to launch or configure it: - python/settings_app/ (the app itself) - vega-settings (launcher script) - vegasettings.desktop + vegastrike_settings.png (its menu entry + icon) - setup.config (config for the legacy vscsetup utility) - vsinstall.sh (pre-0.10 installer that launched vegasettings) and drop their CMake install rules.
The engine no longer parses vegastrike.config; it reads the split JSON config (config.json, bindings.json, theme.json, engine.json) from the data directory plus the user overlay. Remove the file and its CMake install rule, drop the dead settings_app block from config.json (only the removed Kivy app ever wrote it), and update the readme's control instructions to describe the in-game settings screen and bindings.json.
Legacy Python 2 CGI server that rewrote vegastrike.config for account registration. The config XML is gone and the server has not been used in years; drop it and its CMake install rule.
evertvorster
requested review from
BenjamenMeyer,
royfalk and
stephengtuggy
and removed request for
stephengtuggy
September 19, 2026 12:21
…settings # Conflicts: # python/settings_app/templates/advanced_template.json
Multiplayer is not supported at this time outside the 0.5 Legacy edition, so remove the ALPHA Online Multiplayer Mode section (LAN/Deathmatch and MMO style play), its Contents entry, the stale New Features bullet, and renumber the License section. Addresses stephengtuggy's and BenjamenMeyer's review comments on #296.
Addresses stephengtuggy's review comment on #296.
…settings # Conflicts: # python/settings_app/templates/advanced_template.json
royfalk
approved these changes
Sep 30, 2026
royfalk
left a comment
royfalk
left a comment
Contributor
There was a problem hiding this comment.
Seems pretty straightforward to me.
One nitpick comment.
Ship it!
He is the project lead, alongside the other authors already listed.
evertvorster
added a commit
that referenced
this pull request
Oct 2, 2026
Multiplayer is not supported at this time outside the 0.5 Legacy edition, so remove the ALPHA Online Multiplayer Mode section (LAN/Deathmatch and MMO style play), its Contents entry, the stale New Features bullet, and renumber the License section. Addresses stephengtuggy's and BenjamenMeyer's review comments on #296.
Contributor
There was a problem hiding this comment.
Actually, is this the file that the config auto-generation used as a source? As such, do we want to keep it?
Contributor
There was a problem hiding this comment.
If it is the file I'm thinking of, it could potentially be used both to auto-generate additional settings UI elements in the new config screen, and as a source of truth for what all the available settings are, along with their default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You all knew this was coming sometime.
This PR retires all other settings and associated old stuff that is not needed anymore.
Please answer the following:
Code Changes:
Issues:
Purpose: