Repository navigation
config.json: draw the base location markers again - #301
Open
evertvorster wants to merge 1 commit into
Open
evertvorster wants to merge 1 commit into
evertvorster wants to merge 1 commit into
Conversation
base_locationmarker.spr is still in the pack and the engine still draws it at the centre of every hotspot -- the sprite the player is meant to see as they move the cursor towards a clickable area. The setting that names it was never carried into the JSON config, so it has been empty since the split, and the marker has not been drawn at all. Vega Strike 0.5.4's vegastrike.config named the sprite; the engine no longer reads the XML. Sets graphics.bases.location_marker_sprite to base_locationmarker.spr, which is the value the old config used and what enable_location_markers and draw_location_text (both already true) were written to work with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base_locationmarker.spr is still in the pack and the engine still draws it at the centre of every hotspot -- the sprite the player is meant to see as they move the cursor towards a clickable area. The setting that names it was never carried into the JSON config, so it has been empty since the split, and the marker has not been drawn at all. Vega Strike 0.5.4's vegastrike.config named the sprite; the engine no longer reads the XML.
Sets graphics.bases.location_marker_sprite to base_locationmarker.spr, which is the value the old config used and what enable_location_markers and draw_location_text (both already true) were written to work with.
Thank you for submitting a pull request and becoming a contributor to Vega Strike: Upon the Coldest Sea.
Please answer the following:
Code Changes:
Issues:
Purpose: