Skip to content

config.json: draw the base location markers again - #301

Open
evertvorster wants to merge 1 commit into
masterfrom
ev-bugfix-base-screen-draw
Open

evertvorster wants to merge 1 commit into
masterfrom
ev-bugfix-base-screen-draw

Conversation

@evertvorster

Copy link
Copy Markdown
Contributor

base_locationmarker.spr is still in the pack and the engine still draws it at the centre of every hotspot -- the sprite the player is meant to see as they move the cursor towards a clickable area. The setting that names it was never carried into the JSON config, so it has been empty since the split, and the marker has not been drawn at all. Vega Strike 0.5.4's vegastrike.config named the sprite; the engine no longer reads the XML.

Sets graphics.bases.location_marker_sprite to base_locationmarker.spr, which is the value the old config used and what enable_location_markers and draw_location_text (both already true) were written to work with.

Thank you for submitting a pull request and becoming a contributor to Vega Strike: Upon the Coldest Sea.

Please answer the following:

Code Changes:

Issues:

  • Please list any related issues

Purpose:

  • What is this pull request trying to do?
    • Sets the config option to draw the base sprite.
  • What release is this for?
    • 0.11
  • Is there a project or milestone we should apply this to?
    • 0.11

base_locationmarker.spr is still in the pack and the engine still draws it at the
centre of every hotspot -- the sprite the player is meant to see as they move the
cursor towards a clickable area. The setting that names it was never carried into
the JSON config, so it has been empty since the split, and the marker has not been
drawn at all. Vega Strike 0.5.4's vegastrike.config named the sprite; the engine
no longer reads the XML.

Sets graphics.bases.location_marker_sprite to base_locationmarker.spr, which is
the value the old config used and what enable_location_markers and
draw_location_text (both already true) were written to work with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant