fix(eslint): fix no-html-link-for-pages to handle custom pageExtensions - #98115
Open
tahiraltundag wants to merge 1 commit into
Open
fix(eslint): fix no-html-link-for-pages to handle custom pageExtensions#98115tahiraltundag wants to merge 1 commit into
tahiraltundag wants to merge 1 commit into
Conversation
Fixes vercel#53473 The rule previously hardcoded js/ts extensions (/\.(j|t)sx?$/), so it ignored custom pageExtensions like "page.tsx" or "mdx". about.page.tsx was treated as /about.page instead of /about, so <a href="/about"> did not trigger the lint error. - Change parseUrlForPages and parseUrlForAppDir to handle any extension (\..+$) - Handles pageExtensions like "page.tsx", "mdx", etc. correctly - Verified with reproduction https://github.com/nnmax/next-eslint-config-reproduction-app - Lint now correctly warns for <a href="/about"> when about.page.tsx exists
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| `${urlprefix}${dirent.name.replace(/^index(\.(j|t)sx?)$/, '')}` | ||
| ) | ||
| // Handle all page extensions (e.g. js, jsx, ts, tsx, mdx, page.tsx, etc.) | ||
| // pageExtensions can be like "page.tsx" which contains a dot, so we match any extension |
Contributor
There was a problem hiding this comment.
Broadened extension regex /\..+$/ misclassifies directories whose name contains a dot (e.g. v1.0, 2024.01) as page files, so they are never recursed into and pages beneath them are dropped from the generated URL list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53473
The rule hardcoded js/ts extensions, so custom pageExtensions like "page.tsx" or "mdx" were ignored.