2bwm: update to 0.4 - #62385
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
In the pre_build function I removed the two sed commands on line 16 and line 17 that added overrides to the Makefile and instead added make_use_env=yes. The sed command on line 18 was removed since everything builds fine without _GNU_SOURCE. stdlib.h was removed from 2bwm.c in 0.2 so it hasn't been building with _GNU_SOURCE anyways. Also, since 2bwm is customized through a config.h file I thought it would be a good idea to include it if one is found in the files directory.
Local build testing