Repository navigation
fix: use Vite mode to select the built package for tests - #2995
Merged
Merged
Conversation
The command meant to test the **built package** was accidentally testing the **source code** instead. There were two different settings involved: - `test:build` set the test **mode** to `test-build`. - The configuration checked **NODE_ENV**, which still said `test`. Because it checked the wrong setting, it loaded the source code. So a green “build test” run didn’t actually tell us whether the built package worked.
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command meant to test the built package was accidentally testing the source code instead.
There were two different settings involved:
test:buildset the test mode totest-build.test.Because it checked the wrong setting, it loaded the source code. So a green “build test” run didn’t actually tell us whether the built package worked.