Repository navigation
fix: only apply stubs to the app being rendered - #2997
Open
ValentinYoushkevich wants to merge 1 commit into
Open
ValentinYoushkevich wants to merge 1 commit into
ValentinYoushkevich wants to merge 1 commit into
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mount,shallowMountandrenderToStringinstall their stubs with Vue's globaltransformVNodeArgsand never remove them, so any other app rendered later in the same file still gets stubbed, even afterunmount():The same happens with
createSSRApp+@vue/server-renderer(<transition-stub>in the server HTML, hydration mismatch), and a wrapper mounted earlier re-renders with the stubs of the last mounted one. Repro: playground (2.5.1), playground (main)The transformer of each app is now stored in a
WeakMapkeyed by the app, and a single dispatcher installed withtransformVNodeArgsapplies the one of the app being rendered (vnodes created outside of any component still use the last mounted wrapper's transformer). Since every transformer now only sees its own app, themountedRootComponentsset from #2890 is no longer needed and is removed (the #2675 test still passes). Note that components rendered by another app, e.g. one created withcreateAppinside a component, are no longer stubbed.Projects working around this in their tests: