Skip to content

feat: Disable setting proxy if profile is selected - #3640

Merged
tw4l merged 1 commit into
mainfrom
frontend-disable-proxy
Sep 23, 2026
Merged

tw4l merged 1 commit into
mainfrom
frontend-disable-proxy

Conversation

@SuaYoo

@SuaYoo SuaYoo commented Sep 11, 2026

Copy link
Copy Markdown
Member

Resolves #3639

Changes

Disables setting crawler proxy if a browser profile is selected, even if the profile does not have a proxy.

Manual testing

  1. Log in as crawler
  2. Go to new workflow
  3. Go to "Browser Settings"
  4. Select a browser profile without a proxy. Verify "Crawler Proxy Server" is disabled

@SuaYoo
SuaYoo requested a review from ikreymer September 11, 2026 02:20
@SuaYoo SuaYoo changed the title feat: Disable setting proxy if proflile is selected feat: Disable setting proxy if profile is selected Sep 15, 2026
@SuaYoo SuaYoo added this to the 1.26 Release milestone Sep 21, 2026
@tw4l
tw4l force-pushed the frontend-disable-proxy branch from 6c8aa1a to 1895d88 Compare September 23, 2026 21:25

@tw4l tw4l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on latest main and tested, looks good, thanks!

@tw4l
tw4l merged commit eeb256c into main Sep 23, 2026
29 checks passed
@tw4l
tw4l deleted the frontend-disable-proxy branch September 23, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Disable setting proxy if any profile is selected

2 participants