Skip to content

fix(sctp): shutdown chunk acks peer cumulative tsn - #329

Open
gBillal wants to merge 1 commit into
webrtc-rs:masterfrom
gBillal:fix/sctp-shutdown-acks-peer-cumulative-tsn
Open

gBillal wants to merge 1 commit into
webrtc-rs:masterfrom
gBillal:fix/sctp-shutdown-acks-peer-cumulative-tsn

Conversation

@gBillal

@gBillal gBillal commented Nov 15, 2026

Copy link
Copy Markdown

I was doing some interop test with this lib and found this issue. SHUTDOWN chunk acks the sender cumulative tsn instead of the peer cumulative tsn.

@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (0fbcaa7) to head (1806805).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   88.47%   88.53%   +0.05%     
==========================================
  Files         512      512              
  Lines       75483    75499      +16     
==========================================
+ Hits        66787    66841      +54     
+ Misses       8696     8658      -38     
Flag Coverage Δ
aws-lc-rs 88.23% <100.00%> (-0.01%) ⬇️
ring 88.52% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant