Repository navigation
feat: add support subscription mode by unsubscribing button - #37
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
rainliu
left a comment
There was a problem hiding this comment.
see SDP RFC: https://www.rfc-editor.org/info/rfc8866/#section-6.7
| client_id: ClientId, | ||
| reason: String, | ||
| }, | ||
| Subscribe { |
There was a problem hiding this comment.
actually, subscribe/unsubscribe can be implemented via existing SessionDescription event without introducing new Event.
In sdp: RTCSessionDescription of SessionDescription event, just set a=inactive to unsubscribe, and use a=recvonly to subscribe.
There was a problem hiding this comment.
updated with reset the old commit since there is unrelated to direction that we want.
|
thanks for updating PR. Please fix clippy/fmt issue before merge |
#32
Screen.Recording.2026-08-19.at.12.41.42.AM.mp4