Skip to content

feat: add support subscription mode by unsubscribing button - #37

Merged
rainliu merged 2 commits into
webrtc-rs:masterfrom
vicheanath:feat/play
Sep 4, 2026
Merged

rainliu merged 2 commits into
webrtc-rs:masterfrom
vicheanath:feat/play

Conversation

@vicheanath

@vicheanath vicheanath commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor
  • set a=inactive to unsubscribe, and use a=recvonly to subscribe.
  • store unsubscribed in client

#32

Screen.Recording.2026-08-19.at.12.41.42.AM.mp4

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@rainliu rainliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/event.rs Outdated
client_id: ClientId,
reason: String,
},
Subscribe {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, subscribe/unsubscribe can be implemented via existing SessionDescription event without introducing new Event.

In sdp: RTCSessionDescription of SessionDescription event, just set a=inactive to unsubscribe, and use a=recvonly to subscribe.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated with reset the old commit since there is unrelated to direction that we want.

@rainliu

rainliu commented Sep 3, 2026 •

Copy link
Copy Markdown
Member

thanks for updating PR. Please fix clippy/fmt issue before merge

@rainliu
rainliu merged commit 409f14b into webrtc-rs:master Sep 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants