feat(cli): select terminal hosts from command declarations - #740
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
skhaz
approved these changes
Sep 13, 2026
skhaz
approved these changes
Sep 16, 2026
The launcher fetched and decoded the command entry twice, once for security and once for the host, and compared the host kind against a string literal beside the exported constant. It now loads the metadata once and hands it to both; the explicit --host flag's precedence lives in the resolver where a test can prove it, and the test command's help text matches what the path does.
skhaz
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing a dependency that contains a second
terminal.hostcurrently prevents an application's named command from starting: host auto-detection becomes ambiguous even though the application knows which host it uses.Allow
meta.command.host: namespace:nameto declare that host. An explicit--hostretains precedence; commands without a declaration retain single-host discovery. Malformed declarations, missing hosts and non-terminal hosts fail before process creation. Selecting a host does not add actor or policy grants.Validation: focused metadata/security/host tests and the full
cmd/wippy/cmdrace suite pass; current golangci-lint reports zero issues. Tests cover two installed hosts, undeclared ambiguity, missing/wrong-kind targets and malformed metadata. Bee's actual offline restart reproduction reached this ambiguity after its separately diagnosed artifact-cache failure was removed; final Bee integration acceptance follows the runtime build.