Repository navigation
Conversation
@SomethingNew71 proposed some contributions from his fork at ClassicMiniDIY/WireViz in #316 (comment)
The fork used these existing upstream PRs as the foundation, so we might consider cross-checking and adding some of them. I added checkmarks for easier comparison with the list above:
Some of the following bugfixes come additional, but they do not have an upstream issue or PR to be listed here anyway:
Many more changes were applied in additional batches, each covering multiple issues at once. These would need to be broken down into smaller pieces for reviewability. See 2026-10-02-upstream-issue-triage.md and 2026-10-02-batch-c-design.md for details. |
|
Hi @kvid, Regarding "Any other candidates?", I'd like to propose three small PRs, all based on
Some context: WireViz is one of the diagram libraries available on Kroki, which renders diagrams from textual descriptions over HTTP. Kroki pipes the YAML into WireViz and reads the SVG back from stdout. Since this isn't supported upstream, we've been maintaining a fork (yuzutech/WireViz) since 2023, still based on v0.3.2. Getting these changes into v0.4.2 would allow us to drop the fork and offer an up-to-date WireViz to Kroki users. The changes are limited to the CLI and I'm happy to address any feedback, or to rebase onto |
|
@ggrossetie No doubt that #513 qualifies for this bugfix release, but I think that changing the output stream in #321 and #512 are significant changes. The latter should rather be in 0.5, but anyway I vote for this when it improves error detection for nanangp/vscode-wireviz-preview#7, which would work even better with this: Additionally we could add some documentation or template fixes without risk: Also I suggest to cherry-pick 22c5250 that was suggested here: |
|
Thanks @martinrieder for taking the time to consider my changes for this release. Fair point. I agree #321 is a larger change (it also touches the Python API, e.g. #512 is much narrower: generated files are unchanged, only diagnostic messages move from stdout to stderr. The only consumers affected would be tools parsing stdout to capture warnings, and they get a cleaner contract in return (stdout for output, stderr for diagnostics), which is exactly what helps nanangp/vscode-wireviz-preview#7. Since we're still in 0.x, I think it's acceptable in 0.4.2 as long as it's called out explicitly in the CHANGELOG, something like: "Breaking: warnings and progress messages are now written to stderr instead of stdout. If you were capturing them from stdout, read stderr instead. |
a591490 to
7ef9c6b
Compare
Unfortunately, the v0.5 is still not close to finished, and I therefore in the meantime prepare a small release by collecting into this branch some PRs with bug-fixes and other small changes that should be easy to merge into the v0.5-dev branch later.